This part is unnecessary in wgpu_integration.rs #5043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Sep 1, 2024
Comment on lines
555
to
591
| let clear_color = self | ||
| .app | ||
| .clear_color(&self.integration.egui_ctx.style().visuals); | ||
|
|
||
| let has_many_viewports = self.glutin.borrow().viewports.len() > 1; | ||
| let clear_before_update = !has_many_viewports; // HACK: for some reason, an early clear doesn't "take" on Mac with multiple viewports. | ||
|
|
||
| if clear_before_update { | ||
| // clear before we call update, so users can paint between clear-color and egui windows: | ||
|
|
||
| let mut glutin = self.glutin.borrow_mut(); | ||
| let GlutinWindowContext { | ||
| viewports, | ||
| current_gl_context, | ||
| not_current_gl_context, | ||
| .. | ||
| } = &mut *glutin; | ||
| let viewport = &viewports[&viewport_id]; | ||
| let Some(window) = viewport.window.as_ref() else { | ||
| return Ok(EventResult::Wait); | ||
| }; | ||
| let Some(gl_surface) = viewport.gl_surface.as_ref() else { | ||
| return Ok(EventResult::Wait); | ||
| }; | ||
|
|
||
| let screen_size_in_pixels: [u32; 2] = window.inner_size().into(); | ||
|
|
||
| { | ||
| frame_timer.pause(); | ||
| change_gl_context(current_gl_context, not_current_gl_context, gl_surface); | ||
| frame_timer.resume(); | ||
| } | ||
|
|
||
| self.painter | ||
| .borrow() | ||
| .clear(screen_size_in_pixels, clear_color); | ||
| } |
There was a problem hiding this comment.
Doesn't this break test_inline_glow_paint?
There was a problem hiding this comment.
Doesn't this break
test_inline_glow_paint?
(The plan was to PR wgpu and glow separately.)
There was a problem hiding this comment.
Doesn't this break
test_inline_glow_paint?
As planned, I will test glow separately and if there are no issues, I will PR again.
It was a mistake that I didn't check to make sure that glow was included in this PR. Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part is unnecessary, as we call
remove_viewports_not_in()in thehandle_viewport_output()function right before it.